Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GeoMechanicsApplication] Remove duplicated member functions of SmallStrainUPwDiffOrderElement #12466

Closed
markelov208 opened this issue Jun 14, 2024 · 0 comments · Fixed by #12467
Assignees

Comments

@markelov208
Copy link
Contributor

Acceptance Criteria

Member functions that duplicate the functionality as implemented by its new base class (i.e. UPwBaseElement) have been removed.

Implementation Details

The following member functions have been deemed to be duplicates of the base class's ones (i.e. they are identical to the ones of class UPwBaseElement):

  • CalculateDampingMatrix
  • CalculateIntegrationCoefficient
  • CalculateIntegrationCoefficients
  • CalculateLeftHandSide
  • CalculateLocalSystem
  • CalculateOnIntegrationPoints (only the overload that accepts a Variable<ConstitutiveLaw::Pointer> instance)
  • CalculateRightHandSide
  • EquationIdVector
  • GetDofList
  • GetFirstDerivativesVector
  • GetIntegrationMethod
  • GetSecondDerivativesVector
  • ResetConstitutiveLaw
  • SetValuesOnIntegrationPoints (only the overloads that accept Variable<double> or Variable<Matrix> instances)

If one or more of these functions are not covered, first tests should be added, in a different issue.

@markelov208 markelov208 converted this from a draft issue Jun 14, 2024
@markelov208 markelov208 self-assigned this Jun 14, 2024
@rfaasse rfaasse moved this from 👷 In Progress to 👀 In Review in Kratos Product Backlog Jun 19, 2024
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in Kratos Product Backlog Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant