Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It's too laggy #17

Closed
akhnati opened this issue Apr 6, 2020 · 12 comments
Closed

It's too laggy #17

akhnati opened this issue Apr 6, 2020 · 12 comments

Comments

@akhnati
Copy link

akhnati commented Apr 6, 2020

The flag and the page it self is toog laggy, the flag does wave, but it doesn't look good, the "all options" menu takes a while to open.

This problem has been going on for 2 months; i'm currently using Windows 10, and the problem is problem this problem is only happening to me.

@krikienoid
Copy link
Owner

What browser are you using?
Are you using your own images in the flagwaver?
Can you open your developer console and see if there are any errors or warnings popping up?
This kind of stuff is difficult to troubleshoot without a lot of details to go off of

@akhnati
Copy link
Author

akhnati commented Apr 6, 2020

I am using Google Chrome,
The page opens up already laggy,
And i can open the developer control but no warnings appear.

@krikienoid
Copy link
Owner

That's really strange! Again, I don't really know what's going on as I don't see any issues on my end, but any more info you can provide would help.

  1. Are you able to go into the Performance tab of the dev tools, record about 10 seconds or so (but make sure the page is finished loading first), and send me the Profile?

  2. Can you also visit the test page and see if it is any better?

  3. Can you provide screenshots of 1 and 2?

@KyLeggiero
Copy link

It's probably a hardware problem. It's not exactly the smoothest on my 5-year-old MacBook Pro; I can imagine it'd be very intense for old or low-end machines

@krikienoid
Copy link
Owner

I agree that's probably likely, but I'd still like to see more detailed information to see if there's something that can actually be done about it.

Did you see any difference between the test page and the current live version? This would determine if we had a regression and would help pin-point the issue to a specific code change. Other than that though, I would have no idea where else to look.

@KyLeggiero
Copy link

KyLeggiero commented Apr 17, 2020

@krikienoid sorry; I don't think I'll have time to test that out. I can make a note to check back in awhile to tell you if the now-in-test-but-will-then-have-been-the-live-version works the same or not; currently it just barely achieves full FPS for me.

@KyLeggiero
Copy link

Turns out I found some time! So I tested the live version, the test page you linked, and the version on master as cloned onto and running from my machine. Here's my results!


Here's how the live version performs for me:
Screen Shot 2020-04-30 at 21 14 57

Here's how the test page performs for me:
Screen Shot 2020-04-30 at 21 11 21

Here's how the current version on master performs for me:
The `master` branch version


Seems whatever performance enhancements you made for the test version really worked out 😁

@krikienoid
Copy link
Owner

Thanks for the confirmation! Unfortunately, the test version isn't an enhanced version, it's just reverting back to a really old version. Now the hard part is finding out which commit(s) caused the performance drop.

@KyLeggiero
Copy link

Best of luck, @krikienoid! I'm facing the same problem at work lol

@LugiKOOLAIDGamer
Copy link

I have the same problem, It's very laggy

@krikienoid
Copy link
Owner

I've done some tests using the Chrome dev tools Performance tab. I've tried throttling the CPU 6x and comparing Profiles, however, I do not see any noticeable difference. On my machine, both sites run smoothly at 60fps. I've also tried making the main loop function run multiple times per frame, but I was not able to get the latest FlagWaver to perform worse comparatively.

So I think I'll need help from someone with an old computer to pinpoint this issue. If anyone has an old computer, can you test the following links and see which ones perform better/worse?

https://krikienoid.github.io/flagwavertest/tests/v1.0.0/
https://krikienoid.github.io/flagwavertest/tests/2499b32/
https://krikienoid.github.io/flagwavertest/tests/7c4925f/
https://krikienoid.github.io/flagwavertest/tests/af299bd/

@krikienoid
Copy link
Owner

It's been over a year of no activity so I am closing this. If anyone still having issues wants to reopen this, please provide actionable information, such as identifying a specific commit or piece of code that is causing problems, or proposing a fix.

krikienoid added a commit that referenced this issue Jul 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants