Fix code scanning alert no. 1: DOM text reinterpreted as HTML #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: Phileco <132178579+krishnprakash@users.noreply.github.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| var script = document.createElement("script") ; | ||
| script.innerHTML = 'window.json = ' + text + ';'; | ||
| var script = document.createElement("script"); | ||
| script.innerHTML = 'window.json = ' + JSON.stringify(JSON.parse(text)) + ';'; |
Check warning
Code scanning / CodeQL
DOM text reinterpreted as HTML Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 11 months ago
To fix the problem, we need to ensure that the text content is safely handled and not directly inserted into the DOM as HTML. One effective way to do this is to use textContent instead of innerHTML when creating the script element. This will prevent the browser from interpreting the text as HTML, thereby mitigating the risk of XSS.
- Replace the use of
innerHTMLwithtextContentfor the script element. - Ensure that the JSON data is properly escaped and handled as plain text.
Suggested changeset
1
extension/src/json-viewer/viewer/expose-json.js
| @@ -8,3 +8,3 @@ | ||
| var script = document.createElement("script"); | ||
| script.innerHTML = 'window.json = ' + JSON.stringify(JSON.parse(text)) + ';'; | ||
| script.textContent = 'window.json = ' + JSON.stringify(JSON.parse(text)) + ';'; | ||
| document.head.appendChild(script); |
Copilot is powered by AI and may make mistakes. Always verify output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/krishnprakash/json-viewer/security/code-scanning/1
To fix the problem, we need to ensure that the
textvariable is properly sanitized or escaped before being inserted into theinnerHTMLof the script element. One effective way to do this is to useJSON.stringifyto safely encode thetextvariable, which will escape any potentially harmful characters.extension/src/json-viewer/viewer/expose-json.jsto useJSON.stringifyon thetextvariable before inserting it into theinnerHTMLof the script element.exposeJsonfunction inextension/src/json-viewer/viewer/expose-json.js.Suggested fixes powered by Copilot Autofix. Review carefully before merging.