fix: value fetched at the end must be a string

Closes #661
krisk · May 11, 2022 · 1de1dff · 1de1dff
1 parent 18df773
commit 1de1dff
Show file tree

Hide file tree

Showing 12 changed files with 23 additions and 16 deletions.
diff --git a/dist/fuse.basic.common.js b/dist/fuse.basic.common.js
@@ -564,7 +564,7 @@ var FuseIndex = /*#__PURE__*/function () {
 
             record.$[keyIndex] = subRecords;
           })();
-        } else if (!isBlank(value)) {
+        } else if (isString(value) && !isBlank(value)) {
           var subRecord = {
             v: value,
             n: _this3.norm.get(value)

diff --git a/dist/fuse.basic.esm.js b/dist/fuse.basic.esm.js
@@ -435,7 +435,7 @@ class FuseIndex {
           } else ;
         }
         record.$[keyIndex] = subRecords;
-      } else if (!isBlank(value)) {
+      } else if (isString(value) && !isBlank(value)) {
         let subRecord = {
           v: value,
           n: this.norm.get(value)

diff --git a/dist/fuse.basic.esm.min.js b/dist/fuse.basic.esm.min.js
diff --git a/dist/fuse.basic.js b/dist/fuse.basic.js
@@ -568,7 +568,7 @@
 
               record.$[keyIndex] = subRecords;
             })();
-          } else if (!isBlank(value)) {
+          } else if (isString(value) && !isBlank(value)) {
             var subRecord = {
               v: value,
               n: _this3.norm.get(value)

diff --git a/dist/fuse.basic.min.js b/dist/fuse.basic.min.js
diff --git a/dist/fuse.common.js b/dist/fuse.common.js
@@ -647,7 +647,7 @@ var FuseIndex = /*#__PURE__*/function () {
 
             record.$[keyIndex] = subRecords;
           })();
-        } else if (!isBlank(value)) {
+        } else if (isString(value) && !isBlank(value)) {
           var subRecord = {
             v: value,
             n: _this3.norm.get(value)

diff --git a/dist/fuse.esm.js b/dist/fuse.esm.js
@@ -433,7 +433,7 @@ class FuseIndex {
           } else ;
         }
         record.$[keyIndex] = subRecords;
-      } else if (!isBlank(value)) {
+      } else if (isString(value) && !isBlank(value)) {
         let subRecord = {
           v: value,
           n: this.norm.get(value)

diff --git a/dist/fuse.esm.min.js b/dist/fuse.esm.min.js
diff --git a/dist/fuse.js b/dist/fuse.js
@@ -651,7 +651,7 @@
 
               record.$[keyIndex] = subRecords;
             })();
-          } else if (!isBlank(value)) {
+          } else if (isString(value) && !isBlank(value)) {
             var subRecord = {
               v: value,
               n: _this3.norm.get(value)

diff --git a/dist/fuse.min.js b/dist/fuse.min.js
diff --git a/src/tools/FuseIndex.js b/src/tools/FuseIndex.js
@@ -129,7 +129,7 @@ export default class FuseIndex {
           }
         }
         record.$[keyIndex] = subRecords
-      } else if (!isBlank(value)) {
+      } else if (isString(value) && !isBlank(value)) {
         let subRecord = {
           v: value,
           n: this.norm.get(value)

diff --git a/test/fuzzy-search.test.js b/test/fuzzy-search.test.js
@@ -344,7 +344,6 @@ describe('Recurse into arrays', () => {
   })
 })
 
-
 describe('Recurse into objects in arrays with null object in array', () => {
   const customBookList = [
     {
@@ -381,7 +380,7 @@ describe('Recurse into objects in arrays with null object in array', () => {
           {
             value: 'British'
           },
-          null,
+          null
         ]
       }
     }
@@ -401,13 +400,12 @@ describe('Recurse into objects in arrays with null object in array', () => {
       expect(result).toHaveLength(1)
     })
 
-    test('whose value is the ISBN of the book', () => {      
+    test('whose value is the ISBN of the book', () => {
       expect(result[0].item.ISBN).toBe('0321784421')
     })
   })
 })
 
-
 describe('Recurse into objects in arrays', () => {
   const customBookList = [
     {
@@ -1193,12 +1191,21 @@ describe('Standard dotted keys', () => {
 })
 
 describe('Breaking values', () => {
-  test('Non-strings are still processed', () => {
+  test('Booleans are still processed', () => {
     const data = [{ first: false }]
     const options = { keys: [{ name: 'first' }] }
     const fuse = new Fuse(data, options)
 
     const result = fuse.search('fa')
     expect(result).toHaveLength(1)
   })
+
+  test('Object values are ignored', () => {
+    const data = [{ a: 'hello' }, { a: {} }]
+    const options = { keys: ['a'] }
+    const fuse = new Fuse(data, options)
+
+    const result = fuse.search('hello')
+    expect(result).toHaveLength(1)
+  })
 })