Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not return partial matches for threshold 0 #766

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: do not return partial matches for threshold 0 #766

wants to merge 1 commit into from

Conversation

RomanHotsiy
Copy link

Fixes #762

@RomanHotsiy
Copy link
Author

Hey @krisk 🙌

Thanks for the great lib! I hit one problem and noticed it was already reported #762 so I decided to fix it.

The fix is one-liner and I added a unit test to cover it.

Please, let me know if you want me to adjust something or if you feel this is not a good fit in general (so I will maintain a fork or implement a workaround on top). Thanks in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

All indices return with threshold = 0 aren't a perfect match
1 participant
@RomanHotsiy