Skip to content

Conversation

krmroland
Copy link
Owner

@krmroland krmroland commented Aug 26, 2018

What does this PR do?

Currently, all configuration values are placed in a single config file including those that should be kept secret e.g the Database Variables

This PR gives an opportunity to put the secret variables in a private .env whose values can be exported to environmental variables using python-dotenv.

How should this be manually tested?

Since the variables located in the .env are secret variables, .env is blacklisted from VCS, however an example of how the .env file looks like is given, just rename .env.example to .env and replace the dummy values with actual values

  • Refer to README.md for setup instructions

What are the relevant pivotal tracker stories?

#160045670

@coveralls
Copy link

Pull Request Test Coverage Report for Build 82

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 77: 0.0%
Covered Lines: 163
Relevant Lines: 163

💛 - Coveralls

@krmroland
Copy link
Owner Author

@RachaelNantale, How about this??

@krmroland krmroland merged commit 27b55f2 into develop Aug 26, 2018
@krmroland krmroland deleted the 160045670-load-secret-configuration branch August 26, 2018 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants