ci: add cpplint #74
Merged
ci: add cpplint #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Insun35
requested review from
chokobole,
dongchangYoo,
TomTaehoonKim,
Leegwangwoon and
lightscale-luke
Closed
chokobole
requested changes
Oct 5, 2023
tachyon/math/elliptic_curves/msm/algorithms/bellman/bellman_msm.h
Outdated
Show resolved
Hide resolved
tachyon/math/polynomials/univariate/univariate_polynomial_ops.h
Outdated
Show resolved
Hide resolved
Insun35
force-pushed
the
ci/add-cpplint
branch
4 times, most recently
from
d6d82fb
to
e3673eb
Compare
Insun35
force-pushed
the
ci/add-cpplint
branch
from
e3673eb
to
8fc7607
Compare
chokobole
requested changes
Oct 6, 2023
Insun35
force-pushed
the
ci/add-cpplint
branch
from
8fc7607
to
47d502d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds cpplint to ci to follow the Google style guide and catch minor mistakes.
This linter filters files in the tachyon/base and tachyon/device locations.
For future contributions, it is recommended to install cpplint locally.
See https://github.com/cpplint/cpplint
Disabled feature:
I've also made many trivial fixes throughout the library to pass this linter.
Most of the fixes are of the following types: