Feature/controller for control modes #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
there is another problem in mock mode
both mock and nonMock compiled
Currently it does not update the active controllers, it is have to be resolved
plus waiting for control mode change finishing
|
Comment clearing is nessecery |
VX792
requested changes
May 24, 2023
kuka_rox_hardware_interface/include/kuka_rox_hw_interface/robot_manager_node.hpp
Outdated
Show resolved
Hide resolved
Svastits
requested changes
May 26, 2023
kuka_rox_hardware_interface/include/kuka_rox_hw_interface/robot_manager_node.hpp
Outdated
Show resolved
Hide resolved
kuka_rox_hardware_interface/include/kuka_rox_hw_interface/robot_manager_node.hpp
Outdated
Show resolved
Hide resolved
kuka_rox_hardware_interface/include/kuka_rox_hw_interface/rox_hardware_interface.hpp
Outdated
Show resolved
Hide resolved
|
Please remove this line from the hw_interface (L66): This was added to make the driver work with the new protos until this is merged |
VX792
reviewed
Jun 13, 2023
kuka_rox_hardware_interface/src/mock/os-core-udp-communication/udp_replier_mock.cpp
Show resolved
Hide resolved
Svastits
reviewed
Jun 13, 2023
Svastits
approved these changes
Jun 14, 2023
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.