Cleancode #16
Merged
Cleancode #16
+1,181
−145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
krowinski
commented
Nov 19, 2016
krowinski
commented
- basic implemetation of json binary encoder for mysql 5.7
- config now support ip and host setting
- connection_id correctly decoded
- events dispach now can work with 2.8 lib
- some code cleanup
- added new tests
krowinski
added a commit
that referenced
this pull request
Jul 12, 2017
* change ip to host * tests * tests, support for JSON column type in mysql 5.7 (wip), some clean up * wip json binary decoding * wip json * clean up * clean up * Scrutinizer * Scrutinizer 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.