fix sending more than 16MB #45
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello krowinski
I found one bug.
-- https://dev.mysql.com/doc/internals/en/mysql-packet.html
-- https://dev.mysql.com/doc/internals/en/sending-more-than-16mbyte.html
so I fixed it and you can reference my code and my test Environment.
I think you can have more good solution. :)
Thank A lot~
This is my test Environment.
-- CREATE DATABASE binlog_sample;
-- CREATE TABLE binlog_sample.table1 (id int NOT NULL AUTO_INCREMENT,
data LONGTEXT, admin_id VARCHAR(255), PRIMARY KEY(id)
);
-- INSERT INTO binlog_sample.table1 (data, admin_id) VALUES ({20megadatas}, 'admin1');
-- max_allowed_packet = 32M //default: 16M
-- innodb_log_file_size = 250M //default: 50M
-- ...