Skip to content

Conversation

kobi97
Copy link
Contributor

@kobi97 kobi97 commented Aug 10, 2018

Hello krowinski

I found one bug.

so I fixed it and you can reference my code and my test Environment.

I think you can have more good solution. :)

Thank A lot~


This is my test Environment.

  • mariadb-10.0.27
  • php-mysql-replication 3.0.1 (I have plan to upgrade your lastest version soon.)
  • QUERY
    -- CREATE DATABASE binlog_sample;
    -- CREATE TABLE binlog_sample.table1 (id int NOT NULL AUTO_INCREMENT,
    data LONGTEXT, admin_id VARCHAR(255), PRIMARY KEY(id)
    );
    -- INSERT INTO binlog_sample.table1 (data, admin_id) VALUES ({20megadatas}, 'admin1');
  • My.cnf
    -- max_allowed_packet = 32M //default: 16M
    -- innodb_log_file_size = 250M //default: 50M
    -- ...

@krowinski
Copy link
Owner

Great job! Tx

@krowinski krowinski merged commit cef01da into krowinski:master Aug 10, 2018
@kobi97 kobi97 deleted the fix/sending_more_than_16mbyte branch August 10, 2018 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants