fix - some bugs (query event, timestamp, comment/enum types) #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 1.wrong calculation for query in query event
- ref https://github.com/noplay/python-mysql-replication/blame/master/pymysqlreplication/event.py
- 2. support timestamp for column data
- error: Unknown row type: 7
- 3. use db charset
- encoding problem form comment/enum types which include unicode.
|
Great job Tx for merge ! |
krowinski
added a commit
that referenced
this pull request
Jul 12, 2017
fix - some bugs (query event, timestamp, comment/enum types)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello krowinski
I am newbie.
I found some simple bugs. (in mariadb-10.0.26)
cf) python-mysql-replication/blame/master/pymysqlreplication/event.py
error: Unknown row type: 7
encoding problem for comment/enum types which include unicode.
thank you for reading :)