dependency notation does not support maven version range syntax containing `)` and `,`

[NikkyAI]

EDIT: Maven supports version ranges natively: examples: http://www.mojohaus.org/versions-maven-plugin/examples/resolve-ranges.html
an it works in kscript once the annotation and comment parsing is not messing up on , and )

old issue content:

i am writing a library and tool that i try to make compatilble / consumable by kscript
the versions are pushed to maven by jenkins , each git commit increments the build number

ideally i would like to use

@file:DependsOnMaven("moe.nikky.voodoo:dsl:0.4.0+")

instead of

@file:DependsOnMaven("moe.nikky.voodoo:dsl:0.4.0-132")

[NikkyAI]

related: https://youtrack.jetbrains.com/issue/KT-27051

[holgerbrandl]

Could you point me to some reference docs about dynamic versions? What is the format? Is it "just" about supporting dashes and pluses in the version field of the artifact locator?

[NikkyAI]

gradle docs are not very helpful: https://docs.gradle.org/current/userguide/declaring_dependencies.html#sub:declaring_dependency_with_dynamic_version
seems like they have a open issue about documenting the syntax: gradle/gradle#5603

something else that might be interesting might be dependency locking: https://docs.gradle.org/current/userguide/dependency_locking.html

[holgerbrandl]

Why don't you use jitpack to get temporary artifacts?

[NikkyAI]

i did that but it kept reusing the same -SNAPSHOT version that maven cached and update that only somewhat randomly
aalso jitpack had issues buildingthe software, took way too long compared to a friends jenkins and maven repo

jitpack is a nice concept that did not end up working for me sadly

[holgerbrandl]

Indeed for continuous rebuilding it is sometimes a bit sluggish.

Coming back to the dynamic dependencies. What is the format? Is it "just" about supporting dashes and pluses in the version field of the artifact locator?

In order to support it we would need at least some (unit-)test as the dependency lookup is likely to be replace with a different backend (kotlin-scripting-api, aether from existing PR).

[NikkyAI]

could this be used ? http://ant.apache.org/ivy/history/latest-milestone/ivyfile/dependency.html

or apparently maven itself supports a different notation of version ranges
http://www.mojohaus.org/versions-maven-plugin/examples/resolve-ranges.html

[0.4.0,) would be my usecase, but it breaks currently, i guess because there is no resolve-ranges step

[holgerbrandl]

Would maven support such versions? Since it is the current resolver backend, it would be hard to implement it if not. Or we would need to change until we change to something like kotlin-main-api or aether (see PR).

[NikkyAI]

well i have no experience using POMs directly, but i am currently trying to add mvn versions:resolve-ranges to the maven invocation in kscript

[NikkyAI]

apparently ranges like [1.0,2.0] work, but open ranges eg. [1.0,) are breaking

[NikkyAI]

for some reason [0.4.0,) gets regexed into [0.4.0, which produces errors in maven

EDIT: apparently thats the value passed to the regex already, something in the annotation and //DEPS parsing does splitting on , which seems to break this

[NikkyAI]

so spliting versions with , breaks the input of maven version ranges, once i fixed that (an the tests) everything else works, i think i should PR this and continue the discussion there

PS: the annotation parsing splits on ), replacing this with substringBeforeLast seems reasonable and makes ) useable within the annotation