Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

incorrect header length checks #23

Closed
nmav opened this issue Apr 25, 2016 · 3 comments
Closed

incorrect header length checks #23

nmav opened this issue Apr 25, 2016 · 3 comments
Assignees
@fridex
Labels
bug

Comments

@nmav
Copy link
Member

nmav commented Apr 25, 2016

At: https://github.com/fridex/af_ktls/blob/master/af_ktls.c#L1046
you do not check whether the data received are sufficient before starting reading the header.
@fridex fridex added the bug label Apr 25, 2016
@fridex fridex self-assigned this Apr 25, 2016
@fridex
Copy link
Member

fridex commented Apr 25, 2016 •
edited
Loading

Thanks! There should be also check whether TLS/DTLS record size based on header corresponds to size that was actually peeked.

EDIT: check whether TLS/DTLS record size based on header corresponds to peeked size is actually done

fridex added a commit that referenced this issue May 9, 2016
@fridex
Fix peeked size check
c851e8c 
Check peeked size against minimal record size before accessing header fields.
fixes #23
@fridex fridex mentioned this issue May 9, 2016
Closed
@lancerchao
Copy link
Contributor

This issue can be closed.

@fridex
Copy link
Member

fridex commented Jul 28, 2016

Fixed in #62

@fridex fridex closed this as completed Jul 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fridex fridex

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix peeked size check ktls/af_ktls
3 participants
@fridex @nmav @lancerchao