Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove type assertion as no longer an interface #147

Merged
merged 1 commit into from
Jul 15, 2021
Merged

Remove type assertion as no longer an interface #147

merged 1 commit into from
Jul 15, 2021

Conversation

oogali
Copy link
Contributor

@oogali oogali commented Jul 15, 2021

Fixes #144

@oogali oogali mentioned this pull request Jul 15, 2021
Closed
DataDavD
DataDavD approved these changes Jul 15, 2021
View reviewed changes
Copy link
Contributor

@DataDavD DataDavD left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. This is exactly what I was thinking of for a quick fix 👍 👍 👍. Thank you @oogali !!!!

ktrysmt
ktrysmt approved these changes Jul 15, 2021
View reviewed changes
Copy link
Owner

@ktrysmt ktrysmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, and LGTM.

@ktrysmt ktrysmt merged commit db639bc into ktrysmt:master Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktrysmt ktrysmt ktrysmt approved these changes

@DataDavD DataDavD DataDavD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid type assertion issues for Branch Restrict Tests
3 participants
@oogali @ktrysmt @DataDavD