Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate crds by kubebuilder #11

Closed
wants to merge 1 commit into from
Closed

Generate crds by kubebuilder #11

wants to merge 1 commit into from

Conversation

llhuii
Copy link

@llhuii llhuii commented Feb 19, 2021

fix #10

@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign llhuii after the PR has been reviewed.
You can assign the PR to them by writing /assign @llhuii in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 19, 2021
@llhuii llhuii force-pushed the generate-crds-by-kubebuilder branch from addb9f8 to b39e696 Compare February 19, 2021 06:29
@kubeedge-bot kubeedge-bot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Feb 19, 2021
@kubeedge-bot
Copy link
Collaborator

The following users are mentioned in OWNERS file(s) but are untrusted for the following reasons. One way to make the user trusted is to add them as members of the kubeedge org. You can then trigger verification by writing /verify-owners in a comment.

  • JimmyYang20
    • User is not a member of the org. Satisfy at least one of these conditions to make the user trusted.
    • pkg/OWNERS
  • TymonXie
    • User is not a member of the org. Satisfy at least one of these conditions to make the user trusted.
    • lib/OWNERS
    • pkg/OWNERS
  • jaypume
    • User is not a member of the org. Satisfy at least one of these conditions to make the user trusted.
  • khalid-davis
    • User is not a member of the org. Satisfy at least one of these conditions to make the user trusted.

@llhuii llhuii force-pushed the generate-crds-by-kubebuilder branch from b39e696 to 8c42f4e Compare February 19, 2021 06:30
@llhuii
Copy link
Author

llhuii commented Feb 19, 2021

/verify-owners

@llhuii
Copy link
Author

llhuii commented Feb 19, 2021

/cc @TymonXie @khalid-davis

@kubeedge-bot
Copy link
Collaborator

@llhuii: GitHub didn't allow me to request PR reviews from the following users: TymonXie, khalid-davis.

Note that only kubeedge members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @TymonXie @khalid-davis

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@llhuii
Copy link
Author

llhuii commented Feb 19, 2021

/remove-label do-not-merge/invalid-owners-file

@kubeedge-bot
Copy link
Collaborator

@llhuii: The label(s) /remove-label do-not-merge/invalid-owners-file cannot be applied. These labels are supported: tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash

In response to this:

/remove-label do-not-merge/invalid-owners-file

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@llhuii llhuii force-pushed the generate-crds-by-kubebuilder branch from 8c42f4e to 132531e Compare February 19, 2021 06:53
llhuii
llhuii commented Feb 19, 2021
View reviewed changes
pkg/apis/sedna/v1alpha1/model_types.go Outdated
@@ -22,6 +22,8 @@ import (

// +genclient
// +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object
// +kubebuilder:resource:path=models
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no explict path marker to just use the name of struct Model

@llhuii
Copy link
Author

llhuii commented Feb 19, 2021

all original crd yaml files under build/crds/sedna are deleted

Generating CRDs by kubebuilder's controller-gen
9654d3c 
Instead of manully maintaining these crd yaml files under
build/crds/sedna, we use kubebuilder to generate them.

Signed-off-by: llhuii <liulinghui@huawei.com>
@llhuii llhuii force-pushed the generate-crds-by-kubebuilder branch from 132531e to 9654d3c Compare February 19, 2021 07:00
@llhuii
Copy link
Author

llhuii commented Feb 19, 2021

/cc @fisherxu

@llhuii
Copy link
Author

llhuii commented Feb 23, 2021

/verify-owners

@llhuii
Copy link
Author

llhuii commented Feb 24, 2021

Hi @fisherxu, seems that the prow plugin kubeedge-bot used has a bug due to label "do-not-merge/invalid-owners-file" still attaching this pr.

@fisherxu
Copy link
Member

/verify-owners

@fisherxu fisherxu removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Feb 24, 2021
@fisherxu
Copy link
Member

Has manually removed. @llhuii

@llhuii
Copy link
Author

llhuii commented Feb 26, 2021

/hold
until we have some e2e cases

@kubeedge-bot kubeedge-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 26, 2021
@kubeedge-bot
Copy link
Collaborator

@llhuii: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubeedge-bot kubeedge-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 16, 2021
@llhuii llhuii mentioned this pull request Mar 17, 2021
Closed
@llhuii llhuii mentioned this pull request Mar 27, 2021
Closed
7 tasks
@llhuii
Copy link
Author

llhuii commented Mar 30, 2021 •
edited
Loading

/close
since i cherry-pick this pr into #33

@llhuii llhuii closed this Mar 30, 2021
@llhuii llhuii mentioned this pull request Mar 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chendave chendave Awaiting requested review from chendave

@sids-b sids-b Awaiting requested review from sids-b

@fisherxu fisherxu Awaiting requested review from fisherxu

Assignees
No one assigned
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

generate crds using kubebuilder instead of manully editing
3 participants
@llhuii @kubeedge-bot @fisherxu