Add pod template support #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubeedge-bot
requested review from
jaypume,
JimmyYang20,
khalid-huang and
TymonXie
|
/hold |
kubeedge-bot
added
do-not-merge/hold
llhuii
force-pushed
the
add-pod-template
branch
4 times, most recently
from
088221a
to
89e54d2
Compare
Instead of manully maintaining these crd yaml files under build/crds/sedna, we use kubebuilder to generate them. Signed-off-by: llhuii <liulinghui@huawei.com>
llhuii
force-pushed
the
add-pod-template
branch
2 times, most recently
from
7af9e40
to
41b0940
Compare
|
/hold cancel |
kubeedge-bot
removed
the
do-not-merge/hold
added 13 commits
March 30, 2021 10:16
Signed-off-by: llhuii <liulinghui@huawei.com>
Signed-off-by: llhuii <liulinghui@huawei.com>
Signed-off-by: llhuii <liulinghui@huawei.com>
Signed-off-by: llhuii <liulinghui@huawei.com>
Signed-off-by: llhuii <liulinghui@huawei.com>
since we switch to pod template which has large crd yaml, this would lead to the error `metadata.annotations: Too long: must have at most 262144 bytes` when `kubectl apply -f` Signed-off-by: llhuii <liulinghui@huawei.com>
Signed-off-by: llhuii <liulinghui@huawei.com>
Signed-off-by: llhuii <liulinghui@huawei.com>
Signed-off-by: llhuii <liulinghui@huawei.com>
Signed-off-by: llhuii <liulinghui@huawei.com>
Signed-off-by: llhuii <liulinghui@huawei.com>
Signed-off-by: llhuii <liulinghui@huawei.com>
Signed-off-by: llhuii <liulinghui@huawei.com>
llhuii
force-pushed
the
add-pod-template
branch
from
41b0940
to
d832d48
Compare
1. add 'push' to push gm/lc images 2. add 'push-examples' to push examples images 3. add 'push-all' for both Signed-off-by: llhuii <liulinghui@huawei.com>
llhuii
force-pushed
the
add-pod-template
branch
from
d6ccd1f
to
e63d4a1
Compare
|
/lgtm |
|
I'm going to merge this one now. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: llhuii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubeedge-bot
added
the
approved
This was referenced Mar 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #31 #19