-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Kubeflow 1.4 release blog post #109
add Kubeflow 1.4 release blog post #109
Conversation
@kimwnasptd and @jbottum please review. |
## Kubeflow 1.4 video update and tutorials | ||
|
||
The Kubeflow Working Group representatives have recorded a | ||
[presentation](https://www.youtube.com/kubeflow) on Kubeflow 1.4’s new |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jbottum did you intend to link to a specific video here?
The 1.4 software improvements simplify future feature development by reducing | ||
redundant code, increasing CI/CD, and automating testing. An important delivery | ||
was the new Unified Training Operator for Tensorflow, PyTorch, MXNet, and | ||
XGBoost [PR#1302](https://github.com/kubeflow/tf-operator/pull/1302). 1.4 also |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jbottum we had sentence in the Google doc that read, "For more details, see " after the sentence that ends in the PR link. Let me know when we have the link and I'll add that sentence back.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shannonbradshaw the training blog is developing, https://docs.google.com/document/d/1dGqid1ysz99oTlk56cG9FMHmyeVrDNYSSRG0iWnLMzk/edit. I guess we have 2 ways to handle this 1) the training blog is added and becomes a blocking issue to the KF 1.4 release or we figure another way to promote it (like at the end of the blog were we say look at blog.kubeflow.org for more updates. @johnugeorge I want to support the training blog but I am cautious to make it a blocking issue on the KF 1.4 release for Tuesday. any thoughts ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/cc @kubeflow/wg-training-leads
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jbottum Are we waiting for reviews or any other approval process for training blogpost? How much time does it take to get it reviewed and approved?
/lgtm |
Contents looks good to me. Waiting for @johnugeorge 's confirmation on the linked blog post |
…-release.md Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
Update number of docs PRs to "nearly 50"
Add @jbottom's comment about contributions sentence.
Co-authored-by: Dan Sun <dsun20@bloomberg.net>
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
@shannonbradshaw on line 126, we might want to add a line that reminds folks that KF components versions have their own versioning schemes. Now -> This chart provides links to important details from the Working Groups including their 1.4 tracking issues and change logs, along with their. roadmaps. We might add.... Please note that the Working Groups use version numbers that are specific to their project. As a result, many Kubeflow components, which have been incorporated and tested in Kubeflow 1.4, may have a different version number than 1.4. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nits for pipelines, LGTM overall!
Thank you for the great work!
|
||
Another enhancement to Pipelines is the option to use the | ||
[Emissary executor](https://www.kubeflow.org/docs/components/pipelines/installation/choose-executor/) | ||
for non-docker runtime requirements. In addition, 1.4 can also support metadata |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: "runtime" -> "Kubernetes container runtimes"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @Bobgy! Updated.
</td> | ||
</tr> | ||
<tr> | ||
<td><strong>KF Pipelines</strong></td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Kubeflow Pipelines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @Bobgy! Updated.
<a href="https://github.com/kubeflow/pipelines/blob/master/CHANGELOG.md"> | ||
Pipelines Changelog | ||
</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @zijianjoy
I think https://github.com/kubeflow/pipelines/releases/tag/1.7.0 is a better entrance, because it gives both link to the changelog and link to upgrade notes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with using the tag link that Yuan has provided.
NIT: I am wondering how the 1.4 Tracking Issue
column can help users? But it is fine including them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, I also do not feel the tracking issue is useful to end users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zijianjoy @Bobgy @jbottum I eliminated the tracking issue column.
@shannonbradshaw I am okay if others want to remove the tracking issues, but I would prefer to leave them in. If others want them out and you have the time, please remove. In the same chart (~line 160), the training operators Roadmap is listed as Kubeflow Roadmap...It should be Training Operator Roadmap. Also, KFServing should be 0.6.1, https://github.com/kserve/kserve/releases/tag/v0.6.1...this is on ~line 226 |
Thank you for doing this @shannonbradshaw @jbottum! |
@jbottum I addressed the above over the weekend but forgot to let you know. |
@jbottum I addressed all these comments and pushed the changes. |
Copy edits
/lgtm Can we get another lgtm after my edits? Then I'll approve |
assuming we will edit or add the "presentation" link on line 261 to the 1.4 video (on youtube), then this looks good to me. For reference, the video content is here: https://drive.google.com/file/d/16MPvMI0HOo4FlYu73tTHu22k6AziNbxD/view /lgtm |
Want to wait until that is added? It's processing right now.
…On Tue, Oct 12, 2021 at 11:05 AM Josh Bottum ***@***.***> wrote:
assuming we will edit or add the "presentation" link on line 261 to the
1.4 video (on youtube), then this looks good to me. For reference, the
video content is here:
https://drive.google.com/file/d/16MPvMI0HOo4FlYu73tTHu22k6AziNbxD/view
/ltgm
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#109 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABREJVIOLMX5JUIT7HT2YHDUGR2HPANCNFSM5FUZWYJA>
.
|
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: shannonbradshaw, terrytangyuan, theadactyl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Initial commit of Kubeflow 1.4 blog post on behalf of @jbottum