Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update KServe stats to include KFServing #127

Merged
merged 5 commits into from
Oct 10, 2022

Conversation

yuzisun
Copy link
Member

@yuzisun yuzisun commented Oct 5, 2022

According to original survey results slide 23 33.3% of users are on KFServing and 48.3% of users are on KServe, KServe/KFServing is basically the same component so when talking about stats we should really combine them.

Co-authored-by: Anna <antheaj@vmware.com>
@annajung
Copy link
Member

annajung commented Oct 5, 2022

/lgtm

cc @james-jwu to review

@jbottum
Copy link
Contributor

jbottum commented Oct 5, 2022

/lgtm

@jbottum
Copy link
Contributor

jbottum commented Oct 5, 2022

@yuzisun @annajung one related note, I did a quick search on the answers in the question. 1st on kfserving, which had 50 selections, and then on kfserving;kserve, which had 28, kserve had 78. I believe this may mean that 28 are using both (kfserving and kserve). If we add kserve and kfserving (78+50) and subtract the 28 (the people that use both), we get 100. I think this means the combine % using kfserving or kserve would be 100 / 151 or 66%. Does that sound correct?

@annajung
Copy link
Member

annajung commented Oct 5, 2022

Thanks @jbottum for checking for double responses. That makes sense! I went ahead and checked the raw data (survey results) and here is what I found

  • The question "Which Kubeflow components do you use (or will you use)?" had 147 responses
  • Out of 147 responses, 92 responses contained either KFServing or KServe
  • KFserving appeared in 49 responses
  • KServe appeared in 71 responses
  • There were 28 responses that selected both KFServing and KServe

(49 + 71 - 28) / 147 = 63% total responses for using either KFServing or KServe

With the assumption of 50 / 50 split in those 28 who chose both, we can also come up with ratios of KFServing and KServe

KFServing: (49 - (28 / 2)) / 147 = 24%
KServe: (71 - (28 / 2)) / 147 = 39%

If we don't want to assume 50 / 50 split and show the ratios, maybe we just only show the combined percentage. WDYT

@yuzisun
Copy link
Member Author

yuzisun commented Oct 5, 2022

Thanks @jbottum and @annajung for the further analysis! I think the combined percentage (49 + 71 - 28) / 147 = 63% is reasonable, I can update with that number.

@google-oss-prow google-oss-prow bot removed the lgtm label Oct 5, 2022
@jbottum
Copy link
Contributor

jbottum commented Oct 6, 2022

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Oct 6, 2022
@yuzisun
Copy link
Member Author

yuzisun commented Oct 9, 2022

@james-jwu Can you help approve?

@james-jwu
Copy link
Contributor

Thanks for doing the investigations!
/lgtm
/approve

@google-oss-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: james-jwu, yuzisun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 69eb818 into kubeflow:master Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants