Skip to content

Conversation

SanthoshToorpu
Copy link
Contributor

This is a draft PR for code review @franciscojavierarceo.

Signed-off-by: SanthoshToorpu <toorpusanthosh@gmail.com>
Copy link
Contributor

@franciscojavierarceo franciscojavierarceo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/appprove

this is a good start, i have lots of nits about how there's no testing and what not but we don't need to block something starting.

Signed-off-by: SanthoshToorpu <toorpusanthosh@gmail.com>
Signed-off-by: SanthoshToorpu <toorpusanthosh@gmail.com>
@@ -1,2 +0,0 @@
# docs-agent
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why delete?

Signed-off-by: SanthoshToorpu <toorpusanthosh@gmail.com>
Signed-off-by: SanthoshToorpu <toorpusanthosh@gmail.com>
Signed-off-by: SanthoshToorpu <toorpusanthosh@gmail.com>
Signed-off-by: SanthoshToorpu <toorpusanthosh@gmail.com>
Signed-off-by: SanthoshToorpu <toorpusanthosh@gmail.com>
@franciscojavierarceo
Copy link
Contributor

/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Sep 5, 2025
@franciscojavierarceo
Copy link
Contributor

/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: franciscojavierarceo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [franciscojavierarceo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit dbf4202 into kubeflow:main Sep 5, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants