Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue is resolved by this Pull Request:
Resolves #154
Description of your changes:
Since Tekton allows multiple step spec in a task whereas Argo only allows one container spec per task, it's not obvious for Tekton to tell which step is from the main ContainerOp. Therefore, we want to rename all the containerOp step name to "main" to distinguish between the initContainers and main step.
This has no impact to our existing examples because we just change the container name for logging with the API.
Environment tested:
python --version
): 3.6.4tkn version
): 0.11.3kubectl version
): 1.16/etc/os-release
):