Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename main step name to "main" #156

Merged
merged 2 commits into from
May 20, 2020
Merged

Conversation

Tomcli
Copy link
Member

@Tomcli Tomcli commented May 20, 2020

Which issue is resolved by this Pull Request:
Resolves #154

Description of your changes:
Since Tekton allows multiple step spec in a task whereas Argo only allows one container spec per task, it's not obvious for Tekton to tell which step is from the main ContainerOp. Therefore, we want to rename all the containerOp step name to "main" to distinguish between the initContainers and main step.

This has no impact to our existing examples because we just change the container name for logging with the API.

Environment tested:

  • Python Version (use python --version): 3.6.4
  • Tekton Version (use tkn version): 0.11.3
  • Kubernetes Version (use kubectl version): 1.16
  • OS (e.g. from /etc/os-release):

@kubeflow-bot
Copy link

This change is Reviewable

@Tomcli Tomcli changed the title rename main step name to main Rename main step name to "main" May 20, 2020
@drewbutlerbb4
Copy link
Member

Can we do the same for Task templates created for ResourceOps

In the compiler: _op_to_template.py

In the testdata: resourceop_basic.yaml

@Tomcli
Copy link
Member Author

Tomcli commented May 20, 2020

Thanks @drewbutlerbb4, I addressed the comment.

@drewbutlerbb4
Copy link
Member

/lgtm

@animeshsingh
Copy link
Collaborator

/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: animeshsingh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename Tekton task's main container as "main"
5 participants