Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making Andrew Butler a committer in KFP-Tekton project #356

Merged
merged 1 commit into from
Nov 11, 2020

Conversation

animeshsingh
Copy link
Collaborator

@animeshsingh animeshsingh commented Nov 9, 2020

Promoting @drewbutlerbb4 as a Committer in KFP-Tekton project. He has contributed heavily to the Kubeflow Pipelines Tekton project, supporting KFP UI, Tekton Conditions in the compiler, parser for the Tekton equivalent of the Argo workflow in the KFP-Tekton frontend, parsing and displaying the DAG, retrieving archived logs etc.

Additionally he has sustained record of reviewing PRs and maintaining the project.

PRs Committed
#84
#91
#105
#167
#178
#196
#220
#221
#240
#247
#250
#266
#305
#328
#111
#115
#157

Reviews:
#321
#354
#275
#345
#329
#156
#346
#344
#293
#259

@animeshsingh animeshsingh changed the title Making Andrew Butler an Approver in KFP-Tekton Making Andrew Butler a committer in KFP-Tekton project Nov 9, 2020
@animeshsingh
Copy link
Collaborator Author

animeshsingh commented Nov 9, 2020

/hold

until we get LGTMs from all project committers cc @jlewi @Jeffwan

/assign @Tomcli @ckadner @fenglixa

@Tomcli
Copy link
Member

Tomcli commented Nov 9, 2020

/lgtm

Copy link
Member

@ckadner ckadner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks @drewbutlerbb4 for all your contributions!

@fenglixa
Copy link
Member

/lgtm
Thanks @drewbutlerbb4

@Jeffwan
Copy link
Member

Jeffwan commented Nov 11, 2020

/lgtm

@animeshsingh
Copy link
Collaborator Author

/unhold
/approve

Congrats @drewbutlerbb4 !!!!

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: animeshsingh, ckadner, Jeffwan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [animeshsingh,ckadner]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 7a14599 into master Nov 11, 2020
@jlewi
Copy link
Contributor

jlewi commented Nov 11, 2020

@drewbutlerbb4 congratulations! Thanks for all the great work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants