Remove randomness from condition example #178
Conversation
|
This change is |
There was a problem hiding this comment.
@drewbutlerbb4 -- thanks for taking out the randomness here, however, I do want to retain the fact that the conditions rely on the results/output of a previous "coin flip". I wanted to manipulate the FlipCoinOp to "rig" the coin toss with predictable outcome, i.e.:
flip2 = FlipCoinOp('flip-again', forced_result='tails')
|
Thanks @ckadner, I have addressed your comment. |
|
Can we merge this first, before merging @ckadner e-2-e test with conditional tests enabled |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Tomcli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The unit test for dsl.Condition previously used a random number generator to dictate which event occurred and therefore which condition would execute. This causes issues with consistent testing as there are multiple valid potential outputs. This test has been changed to be deterministic, to address this issue, by using pipeline parameters to dictate which event occurred and setting default values for the pipeline.