Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kfp-tekton deployment instructions and update user guide for multi-user #275

Merged
merged 8 commits into from
Aug 20, 2020

Conversation

Tomcli
Copy link
Member

@Tomcli Tomcli commented Aug 15, 2020

Move website instructions and optimize it for kfp-tekton, also update kfp user guide for multi-user

Which issue is resolved by this Pull Request:
Resolves #

Description of your changes:

Environment tested:

  • Python Version (use python --version):
  • Tekton Version (use tkn version):
  • Kubernetes Version (use kubectl version):
  • OS (e.g. from /etc/os-release):

Checklist:

  • The title for your pull request (PR) should follow our title convention. Learn more about the pull request title convention used in this repository.

    PR titles examples:

    • fix(frontend): fixes empty page. Fixes #1234
      Use fix to indicate that this PR fixes a bug.
    • feat(backend): configurable service account. Fixes #1234, fixes #1235
      Use feat to indicate that this PR adds a new feature.
    • chore: set up changelog generation tools
      Use chore to indicate that this PR makes some changes that users don't need to know.
    • test: fix CI failure. Part of #1234
      Use part of to indicate that a PR is working on an issue, but shouldn't close the issue when merged.
  • Do you want this pull request (PR) cherry-picked into the current release branch?

    If yes, use one of the following options:

    • (Recommended.) Ask the PR approver to add the cherrypick-approved label to this PR. The release manager adds this PR to the release branch in a batch update.
    • After this PR is merged, create a cherry-pick PR to add these changes to the release branch. (For more information about creating a cherry-pick PR, see the Kubeflow Pipelines release guide.)

@kubeflow-bot
Copy link

This change is Reviewable

Copy link
Member

@drewbutlerbb4 drewbutlerbb4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Tomcli just a few minor things

developer_guide.md Outdated Show resolved Hide resolved
samples/kfp-user-guide/README.md Outdated Show resolved Hide resolved
samples/kfp-user-guide/README.md Outdated Show resolved Hide resolved
samples/kfp-user-guide/README.md Outdated Show resolved Hide resolved
Co-authored-by: Andrew Butler <Andrew.Butler@ibm.com>
Copy link
Member

@drewbutlerbb4 drewbutlerbb4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Tomcli I did one more pass through and have some more comments

tekton_kfp_guide.md Outdated Show resolved Hide resolved
tekton_kfp_guide.md Outdated Show resolved Hide resolved
tekton_kfp_guide.md Outdated Show resolved Hide resolved
tekton_kfp_guide.md Outdated Show resolved Hide resolved
tekton_kfp_guide.md Outdated Show resolved Hide resolved
@Tomcli
Copy link
Member Author

Tomcli commented Aug 19, 2020

Thanks @drewbutlerbb4, I was using the kubeflow website instructions as the base so I didn't catch few of the broken links and grammar errors. That's for pointing it out.

@drewbutlerbb4
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot removed the lgtm label Aug 19, 2020
@drewbutlerbb4
Copy link
Member

/lgtm
I have tested the single-user install and works great, thanks @Tomcli

developer_guide.md Outdated Show resolved Hide resolved
developer_guide.md Outdated Show resolved Hide resolved
```

- For multi tenant:
1. `KUBEFLOW_PUBLIC_ENDPOINT_URL` - Kubeflow public endpoint URL.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't endpoint URL be a requirement for both single/multi-user?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a limitation from kfp.
https://www.kubeflow.org/docs/pipelines/multi-user/#when-using-the-sdk
First, you need to connnect to the Kubeflow Pipelines public endpoint using the SDK.

samples/kfp-user-guide/README.md Outdated Show resolved Hide resolved
```

- For multi tenant:
1. `KUBEFLOW_PUBLIC_ENDPOINT_URL` - Kubeflow public endpoint URL.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same - why is endpoint exclusive to multi-user?

samples/kfp-user-guide/README.md Outdated Show resolved Hide resolved
Co-authored-by: Animesh Singh <singhan@us.ibm.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm label Aug 20, 2020
Tomcli and others added 2 commits August 19, 2020 17:35
Co-authored-by: Animesh Singh <singhan@us.ibm.com>
Co-authored-by: Animesh Singh <singhan@us.ibm.com>
@animeshsingh
Copy link
Collaborator

/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: animeshsingh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 5437241 into kubeflow:master Aug 20, 2020
@Tomcli Tomcli mentioned this pull request Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants