-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kfp-tekton deployment instructions and update user guide for multi-user #275
Conversation
… kfp user guide for multi-user
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Tomcli just a few minor things
Co-authored-by: Andrew Butler <Andrew.Butler@ibm.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Tomcli I did one more pass through and have some more comments
Thanks @drewbutlerbb4, I was using the kubeflow website instructions as the base so I didn't catch few of the broken links and grammar errors. That's for pointing it out. |
/lgtm |
/lgtm |
``` | ||
|
||
- For multi tenant: | ||
1. `KUBEFLOW_PUBLIC_ENDPOINT_URL` - Kubeflow public endpoint URL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't endpoint URL be a requirement for both single/multi-user?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a limitation from kfp.
https://www.kubeflow.org/docs/pipelines/multi-user/#when-using-the-sdk
First, you need to connnect to the Kubeflow Pipelines public endpoint using the SDK.
``` | ||
|
||
- For multi tenant: | ||
1. `KUBEFLOW_PUBLIC_ENDPOINT_URL` - Kubeflow public endpoint URL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same - why is endpoint exclusive to multi-user?
Co-authored-by: Animesh Singh <singhan@us.ibm.com>
Co-authored-by: Animesh Singh <singhan@us.ibm.com>
Co-authored-by: Animesh Singh <singhan@us.ibm.com>
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: animeshsingh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Move website instructions and optimize it for kfp-tekton, also update kfp user guide for multi-user
Which issue is resolved by this Pull Request:
Resolves #
Description of your changes:
Environment tested:
python --version
):tkn version
):kubectl version
):/etc/os-release
):Checklist:
The title for your pull request (PR) should follow our title convention. Learn more about the pull request title convention used in this repository.
PR titles examples:
fix(frontend): fixes empty page. Fixes #1234
Use
fix
to indicate that this PR fixes a bug.feat(backend): configurable service account. Fixes #1234, fixes #1235
Use
feat
to indicate that this PR adds a new feature.chore: set up changelog generation tools
Use
chore
to indicate that this PR makes some changes that users don't need to know.test: fix CI failure. Part of #1234
Use
part of
to indicate that a PR is working on an issue, but shouldn't close the issue when merged.Do you want this pull request (PR) cherry-picked into the current release branch?
If yes, use one of the following options:
cherrypick-approved
label to this PR. The release manager adds this PR to the release branch in a batch update.