Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the README for kustomize 4.5.7 support #2362

Conversation

kimwnasptd
Copy link
Member

PR to update the README, based on the progress from #2360

This PR

  1. adds some more troubleshooting notes on the manual installation method
  2. makes it clear when users can use Kustomize 3.2 and when 4.5.7

cc @DomFleischmann @jbottum

We will need to wait for the Cert Manager pods to become Ready, before
applying a ClusterIssuer.

Previously we would get connection refused errors from the K8s API
Server talking to the webhook. A useful troubleshooting guide is:
https://cert-manager.io/docs/troubleshooting/webhook/#error-connect-connection-refused

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kimwnasptd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kimwnasptd kimwnasptd changed the title Feature kimwnasptd manifests manual instructions Update the README for kustomize 4.5.7 support Jan 25, 2023
@elikatsis
Copy link
Member

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Feb 2, 2023
@google-oss-prow google-oss-prow bot merged commit 83aa1ab into kubeflow:master Feb 2, 2023
@elikatsis elikatsis deleted the feature-kimwnasptd-manifests-manual-instructions branch February 2, 2023 12:45
kevin85421 pushed a commit to juliusvonkohout/manifests that referenced this pull request Feb 28, 2023
* Wait for Cert Manager Pods to become Ready

We will need to wait for the Cert Manager pods to become Ready, before
applying a ClusterIssuer.

Previously we would get connection refused errors from the K8s API
Server talking to the webhook. A useful troubleshooting guide is:
https://cert-manager.io/docs/troubleshooting/webhook/#error-connect-connection-refused

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* README: Update instructions for running with Kustomize 4

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

---------

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants