Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix common/istio-cni-1-17/cluster-local-gateway/base kustomize warnings #2649

Conversation

AndersBennedsgaard
Copy link
Contributor

Which issue is resolved by this Pull Request:

Related to #2388

Description of your changes:

Fix Kustomize v5 warnings for common/istio-cni-1-17/cluster-local-gateway/base
kustomize build generates no changes between old and new version.

Checklist:

  • Unit tests pass:
    Make sure you have installed kustomize == 5.0.3
    1. make generate-changed-only
    2. make test

Copy link

google-cla bot commented Mar 13, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AndersBennedsgaard
Once this PR has been reviewed and has the lgtm label, please assign juliusvonkohout for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Anders Bennedsgaard <abbennedsgaard@gmail.com>
@juliusvonkohout
Copy link
Member

@AndersBennedsgaard Please merge those 4 PRs into a single one, close the old ones and tag me. Then i can merge.

@AndersBennedsgaard
Copy link
Contributor Author

Closed in favor of #2653

@AndersBennedsgaard AndersBennedsgaard deleted the fix/istio-cni-warnings branch March 13, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants