Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change extract_images.sh to include Model Registry #2733

Merged
merged 1 commit into from
May 28, 2024

Conversation

rimolive
Copy link
Member

@rimolive rimolive commented May 28, 2024

Pull Request Template for Kubeflow manifests Issues

✏️ A brief description of the changes

Included in hack/extract_images.sh script the Model Registry images.

📦 List any dependencies that are required for this change

N/A

🐛 If this PR is related to an issue, please put the link of the issue here.

N/A

✅ Unit Test Checklist

  • 🛠️ Make sure you have installed kustomize == 5.2.1+
  • ✍️ Have you written new tests for your core changes, as applicable?
  • 🔄 Have you successfully run existing tests with your changes ?
  • 🚀 Have you successfully run existing and new tests with your changes ?

✅ Contributor checklist


You can join our slack channel wg-manifests here. This link also contains our meeting schedule.

Signed-off-by: Ricardo M. Oliveira <rmartine@redhat.com>
@juliusvonkohout
Copy link
Member

/approve

@juliusvonkohout
Copy link
Member

/lgtm

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot added the lgtm label May 28, 2024
@juliusvonkohout juliusvonkohout mentioned this pull request May 28, 2024
2 tasks
@google-oss-prow google-oss-prow bot merged commit ecb199b into kubeflow:master May 28, 2024
3 checks passed
biswajit-9776 pushed a commit to biswajit-9776/manifests that referenced this pull request May 29, 2024
Signed-off-by: Ricardo M. Oliveira <rmartine@redhat.com>
juliusvonkohout pushed a commit that referenced this pull request Jun 4, 2024
Signed-off-by: Ricardo M. Oliveira <rmartine@redhat.com>
doncorsean pushed a commit to doncorsean/kubeflow-manifests that referenced this pull request Jul 18, 2024
Signed-off-by: Ricardo M. Oliveira <rmartine@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants