Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kubeflow/kubeflow manifests from v1.9.0-rc.1 #2781

Conversation

juliusvonkohout
Copy link
Member

@juliusvonkohout juliusvonkohout commented Jun 30, 2024

@rimolive for /lgtm

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

fix the synchronization script

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

fix the synchronization script

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

fix the synchronization script

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

Update kubeflow/kubeflow manifests from v1.9.0-rc.1

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

fix the synchronization script

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

Update kubeflow/kubeflow manifests from v1.9.0-rc.1

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

fix the synchronization script

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

...

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

fix tags

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
@juliusvonkohout
Copy link
Member Author

I think we can adjust the test to just create an experiment etc. But leave out the pipeline execution itself. That should be enough as an authentication test for now.

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
@google-oss-prow google-oss-prow bot removed the approved label Jul 1, 2024
@rimolive
Copy link
Member

rimolive commented Jul 1, 2024

/lgtm

@juliusvonkohout
Copy link
Member Author

/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 38a8183 into master Jul 1, 2024
16 checks passed
@juliusvonkohout juliusvonkohout deleted the synchronize-kubeflow-kubeflow-manifests-v1.9.0-rc.1-second-try branch July 1, 2024 15:45
hansinikarunarathne pushed a commit to hansinikarunarathne/kubeflow-manifests that referenced this pull request Jul 22, 2024
* Update kubeflow/kubeflow manifests from v1.9.0-rc.1

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

fix the synchronization script

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

fix the synchronization script

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

fix the synchronization script

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

Update kubeflow/kubeflow manifests from v1.9.0-rc.1

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

fix the synchronization script

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

Update kubeflow/kubeflow manifests from v1.9.0-rc.1

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

fix the synchronization script

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

...

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

fix tags

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

* update the cicd image

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

* comment out the unreliable test parts.

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

---------

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants