Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two examples for disabling istio injection in kubeflow namespace #703

Merged
merged 1 commit into from
Jan 15, 2020

Conversation

Bobgy
Copy link
Contributor

@Bobgy Bobgy commented Jan 14, 2020

Which issue is resolved by this Pull Request:
Example of #700
Part of kubeflow/pipelines#1223
Unblocks kubeflow/kfctl#131

Description of your changes:
Add istio disable injection annotations for two deployments.

Checklist:

  • Unit tests have been rebuilt:
    1. cd manifests/tests
    2. make generate-changed-only
    3. make test

This change is Reviewable

@Bobgy
Copy link
Contributor Author

Bobgy commented Jan 14, 2020

/cc @jlewi

@Bobgy
Copy link
Contributor Author

Bobgy commented Jan 14, 2020

One problem I realized though, is that, pods generated by all the services also need such annotations. It is not an easy task to adjust every service to let them work in Kubeflow.

I'd still prefer changing cluster default to not inject pods with sidecars.

@jlewi
Copy link
Contributor

jlewi commented Jan 15, 2020

One problem I realized though, is that, pods generated by all the services also need such annotations. It is not an easy task to adjust every service to let them work in Kubeflow.

What's the difficulty?

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit b556503 into kubeflow:master Jan 15, 2020
@Bobgy Bobgy deleted the disable_istio_injection_example branch January 16, 2020 06:04
@Bobgy
Copy link
Contributor Author

Bobgy commented Jan 16, 2020

@jlewi Not exactly difficult, but it's a lot of work to make sure each operator spawn pod (like argo) has an annotation to disable sidecar injection. You should have more context on this. If there isn't many, it's fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants