-
Notifications
You must be signed in to change notification settings - Fork 65
Closed
Labels
area/v1area - version - kubeflow notebooks v1area - version - kubeflow notebooks v1kind/plan-taskkind - planning - taskkind - planning - task
Description
Certification
- I certify I am an Epic Owner for Kubeflow Notebooks 2.0 and expected to create planning-related issues.
Description
To complete the initial migration onto the notebooks-v1
branch - the components/common
folder was migrated over. This module has a simple reconcile
package that defines a few helper functions related to reconciliation of Deployment
, StatefulSet
, Service
, and VirtualService
objects.
@thesuperzapper had mentioned he would prefer we remove this common
folder entirely and simply copy any relevant helper functions into each/every component within notebooks-v1
if/as necessary.
This issue is simply mean to spur discussion and capture the agreed upon decision and rationale behind it.
Acceptance Criteria
- Consensus reached (explicitly or via lazy consensus) on whether or not
common
folder should be removed and logic simply duplicated across any packages currently depending on thereconcile
package
Metadata
Metadata
Assignees
Labels
area/v1area - version - kubeflow notebooks v1area - version - kubeflow notebooks v1kind/plan-taskkind - planning - taskkind - planning - task
Type
Projects
Status
Done