Skip to content

Conversation

franciscojavierarceo
Copy link
Contributor

@franciscojavierarceo franciscojavierarceo commented May 13, 2025

Add adopters.

Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
ADOPTERS.md Outdated
@@ -0,0 +1,9 @@
# Adopters of Kubeflow Notebooks

Below are the adopters of project Pipelines. If you are using Notebooks
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Below are the adopters of project Pipelines.

Copy/paste error? should Pipelines be Notebooks (?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching that! Fixed.

Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
Copy link
Member

@thesuperzapper thesuperzapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@franciscojavierarceo thanks, some questions

cc @ederign

Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
@ederign
Copy link
Member

ederign commented May 13, 2025

/lgtm

@ederign
Copy link
Member

ederign commented May 13, 2025

/approve

@franciscojavierarceo
Copy link
Contributor Author

@thesuperzapper can you approve? I've updated accordingly.

Copy link
Member

@ederign ederign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small suggestion inline

Co-authored-by: Eder Ignatowicz <ignatowicz@gmail.com>
Signed-off-by: Francisco Arceo <farceo@redhat.com>
@google-oss-prow google-oss-prow bot removed the lgtm label Jun 3, 2025
Signed-off-by: Francisco Arceo <farceo@redhat.com>
@thesuperzapper
Copy link
Member

/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Jun 3, 2025
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ederign, thesuperzapper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@thesuperzapper
Copy link
Member

/ok-to-test

@google-oss-prow google-oss-prow bot merged commit 920944f into kubeflow:main Jun 3, 2025
7 checks passed
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in Kubeflow Notebooks Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants