chore: update controller manifests #596
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-oss-prow
bot
added
the
area/controller
andyatmiami
force-pushed
the
chore/controller-kustomize-consistency
branch
from
0e63f95 to
53dd15a
Compare
|
/ok-to-test |
andyatmiami
force-pushed
the
chore/controller-kustomize-consistency
branch
2 times, most recently
from
9fa0e74 to
aa26b04
Compare
This commit brings about various changes to improve naming consistency across the `workspaces/` components.
The original `controller/` manifests were generated by kubebuilder and were not aligned with the conventions we have established in the `backend` and `frontend` components. Changing the manifests also had a "trickle effect" of requiring minor modifications to the `Makefile` as well as some e2e tests and documentation.
Key manifest changes:
- dropped `namePrefix` transformation
- standardized on `kubeflow-workspaces` namespace
- leveraged name of `workspaces-controller` where sensible
- Standardized `app.kubernetes.io/*` labels across all resources
- leveraging `labels` transformation as much as possible
- selectively applied `includeSelectors: true` when appropriate
- Removed legacy control-plane=controller-manager labels
- replaced with appropriate `app.kubernetes.io/*` labels to keep behavioral parity
Signed-off-by: Andy Stoneberg <astonebe@redhat.com>
andyatmiami
force-pushed
the
chore/controller-kustomize-consistency
branch
from
aa26b04 to
0c33757
Compare
thesuperzapper
changed the title
thesuperzapper
approved these changes
Sep 25, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: thesuperzapper The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-oss-prow
bot
merged commit 68d9466
into
kubeflow:notebooks-v2
13 of 14 checks passed
github-project-automation
bot
moved this from Needs Triage
to Done
in Kubeflow Notebooks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ℹ️ : NO GH ISSUE
This commit brings about various changes to improve naming consistency across the
workspaces/components.The original
controller/manifests were generated by kubebuilder and were not aligned with the conventions we have established in thebackendandfrontendcomponents. Changing the manifests also had a "trickle effect" of requiring minor modifications to theMakefileas well as some e2e tests and documentation.Key manifest changes:
namePrefixtransformationkubeflow-workspacesnamespaceworkspaces-controllerwhere sensibleapp.kubernetes.io/*labels across all resourceslabelstransformation as much as possibleincludeSelectors: truewhen appropriateapp.kubernetes.io/*labels to keep behavioral parity