-
Notifications
You must be signed in to change notification settings - Fork 65
ci: add publish workflow for backend #610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add publish workflow for backend #610
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
This commit adds a GHA workflow to support publishing a container image for the `workspaces/backend` component as well as some updates to the `Makefile` to establish reasonable (but overridable) defaults. Key behavior: - Publishes backend image on any workspaces/ directory change - Builds image with commit SHA tags by default - "release" images with use the tag as defined by the `VERSION` file - a `-dirty` suffix is added to the tag if the codebase is not `porcelain` - no `latest` tag is ever produced on images - Uses `ghcr.io/kubeflow/notebooks` registry with configurable naming example image name from "random" commit: - `ghcr.io/kubeflow/notebooks/workspaces-backend:sha-3fa851ab3173942dbaa1a609468e7f9eadf5f4e4` example image name from release: - `ghcr.io/kubeflow/notebooks/workspaces-backend:v2.0.0` Signed-off-by: Andy Stoneberg <astonebe@redhat.com>
448f5a5
to
2f25910
Compare
/close A superior (and cross cutting) solution is being worked as part of #605 |
@andyatmiami: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
related: #607
This commit adds a GHA workflow to support publishing a container image for the
workspaces/backend
component as well as some updates to theMakefile
to establish reasonable (but overridable) defaults.Key behavior:
VERSION
file-dirty
suffix is added to the tag if the codebase is notporcelain
latest
tag is ever produced on imagesghcr.io/kubeflow/notebooks
registry with configurable namingexample image name from "random" commit:
ghcr.io/kubeflow/notebooks/workspaces-backend:sha-3fa851ab3173942dbaa1a609468e7f9eadf5f4e4
example image name from release:
ghcr.io/kubeflow/notebooks/workspaces-backend:v2.0.0