Skip to content

Conversation

andyatmiami
Copy link
Contributor

related: #608

This commit adds a GHA workflow to support publishing a container image for the workspaces/frontend component as well as some updates to the Makefile to establish reasonable (but overridable) defaults.

Key behavior:

  • Publishes frontend image on any workspaces/ directory change
  • Builds image with commit SHA tags by default
    • "release" images with use the tag as defined by the VERSION file
    • a -dirty suffix is added to the tag if the codebase is not porcelain
    • no latest tag is ever produced on images
  • Uses ghcr.io/kubeflow/notebooks registry with configurable naming

example image name from "random" commit:

  • ghcr.io/kubeflow/notebooks/workspaces-frontend:sha-3fa851ab3173942dbaa1a609468e7f9eadf5f4e4

example image name from release:

  • ghcr.io/kubeflow/notebooks/workspaces-frontend:v2.0.0

@github-project-automation github-project-automation bot moved this to Needs Triage in Kubeflow Notebooks Sep 22, 2025
@google-oss-prow google-oss-prow bot added the area/ci area - related to ci label Sep 22, 2025
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kimwnasptd for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot added area/frontend area - related to frontend components area/v2 area - version - kubeflow notebooks v2 size/M labels Sep 22, 2025
@andyatmiami
Copy link
Contributor Author

/ok-to-test

@andyatmiami
Copy link
Contributor Author

Verification on my fork for "typical" code changes:

image

@andyatmiami
Copy link
Contributor Author

Verification on my fork for "release" code changes:

image

Copy link

@paulovmr paulovmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

This commit adds a GHA workflow to support publishing a container image for the `workspaces/frontend` component as well as some updates to the `Makefile` to establish reasonable (but overridable) defaults.

Key behavior:
- Publishes frontend image on any workspaces/ directory change
- Builds image with commit SHA tags by default
    - "release" images with use the tag as defined by the `VERSION` file
    - a `-dirty` suffix is added to the tag if the codebase is not `porcelain`
    - no `latest` tag is ever produced on images
- Uses  `ghcr.io/kubeflow/notebooks` registry with configurable naming

example image name from "random" commit:
- `ghcr.io/kubeflow/notebooks/workspaces-frontend:sha-3fa851ab3173942dbaa1a609468e7f9eadf5f4e4`

example image name from release:
- `ghcr.io/kubeflow/notebooks/workspaces-frontend:v2.0.0`

Signed-off-by: Andy Stoneberg <astonebe@redhat.com>
@andyatmiami andyatmiami force-pushed the chore/publish_frontend_workflow branch from 2fc29a4 to f34c281 Compare September 25, 2025 20:58
@google-oss-prow google-oss-prow bot removed the lgtm label Sep 25, 2025
Copy link

New changes are detected. LGTM label has been removed.

@andyatmiami
Copy link
Contributor Author

/hold

likely will close this unmerged as #605 now handles the logic introduced here.. but will wait until early next week while I test #605

@andyatmiami
Copy link
Contributor Author

/close

A superior (and cross cutting) solution is being worked as part of #605

@google-oss-prow google-oss-prow bot closed this Sep 29, 2025
Copy link

@andyatmiami: Closed this PR.

In response to this:

/close

A superior (and cross cutting) solution is being worked as part of #605

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-project-automation github-project-automation bot moved this from Needs Triage to Done in Kubeflow Notebooks Sep 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci area - related to ci area/frontend area - related to frontend components area/v2 area - version - kubeflow notebooks v2 do-not-merge/hold ok-to-test size/M
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants