Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed reference to non existing path #3743

Merged
merged 1 commit into from
May 24, 2024

Conversation

rajeeshckr
Copy link
Contributor

@rajeeshckr rajeeshckr commented May 24, 2024

Looks like platform-agnostic-pns folder seems to be removed in this commit

I hope platform-agnostic is the new one to use.

Also, there was an error with workflow-controller and metadata-envoy-deployment using the same port causing crash loop. I modified the workflow-controller deployment to change the to a non conflicting port.

image

Copy link

Hi @rajeeshckr. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Looks like `platform-agnostic-pns` folder seems to be removed in kubeflow/pipelines@809d576 commit

Signed-off-by: Rajeesh <rajeesh.ckr@gmail.com>
@hbelmiro
Copy link
Contributor

/ok-to-test

Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@hbelmiro
Copy link
Contributor

@chensun can you PTAL?

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 109f849 into kubeflow:master May 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants