-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed reference to non existing path #3743
Conversation
Hi @rajeeshckr. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Looks like `platform-agnostic-pns` folder seems to be removed in kubeflow/pipelines@809d576 commit Signed-off-by: Rajeesh <rajeesh.ckr@gmail.com>
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@chensun can you PTAL? |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chensun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Looks like
platform-agnostic-pns
folder seems to be removed in this commitI hope
platform-agnostic
is the new one to use.Also, there was an error with
workflow-controller
andmetadata-envoy-deployment
using the same port causing crash loop. I modified theworkflow-controller
deployment to change the to a non conflicting port.