Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instructions for running API reference generation tool #521

Merged
merged 6 commits into from
Mar 6, 2019

Conversation

richardsliu
Copy link
Collaborator

@richardsliu richardsliu commented Mar 6, 2019

Also fixed an incorrect version name in the docs.

Fixes kubeflow/training-operator#731.


This change is Reviewable

@richardsliu richardsliu requested review from sarahmaddox and removed request for nickchase and paveldournov March 6, 2019 03:03
@richardsliu
Copy link
Collaborator Author

/assign @sarahmaddox
/assign @johnugeorge

Copy link
Contributor

@sarahmaddox sarahmaddox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just a few comments for consideration.

gen-api-reference/README.md Outdated Show resolved Hide resolved
gen-api-reference/README.md Show resolved Hide resolved
gen-api-reference/README.md Outdated Show resolved Hide resolved
gen-api-reference/README.md Outdated Show resolved Hide resolved
@sarahmaddox
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sarahmaddox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit bb3ab8a into kubeflow:master Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[doc] API Documentation
4 participants