Add go tests for PRs #326
Merged
Add go tests for PRs #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should fail, as we have borken go tests. |
|
Working as expected! |
|
(I could probably remove the annotation bit, as I don't think it matters, as long as we run the go tests, I am fine with it. WDYT? |
|
I think it's a bonus which could improve the review experience. We can try it and remove it if we don't like this. |
Without this patch, go test bugs can appear without getting caught, neither in periodics, nor in PRs. This should fix it.
|
Rebased. go tests should now work. |
ckotzbauer
approved these changes
Mar 29, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this patch, go test bugs can appear without getting caught.
This should fix it.