Enter host mount namespace #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the tools installed in the host to effect reboots, and allow the execution of commands such as `needs-restart` to determine if reboots are required.
gswallow
reviewed
May 28, 2019
| log.Fatalf("Unable to determine existence of sentinel: %v", err) | ||
| return false // unreachable; prevents compilation error | ||
| // Relies on hostPID:true and privileged:true to enter host mount space | ||
| sentinelCmd := newCommand("/usr/bin/nsenter", "-m/proc/1/ns/mnt", "--", "/usr/bin/test", "-f", rebootSentinel) |
There was a problem hiding this comment.
Whose job is it to remove the /var/run/reboot-required file? Will this result in reboot loops?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the tools installed in the host to effect reboots, eventually facilitating the use of commands such as
needs-restartto determine if reboots are required.