Set current-context for bootstrap kubeconfig #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubermatic-bot
added
release-note-none
|
/assign @kdomanski @nikhita |
themue
approved these changes
Aug 28, 2019
kubermatic-bot
added
the
do-not-merge/hold
|
LGTM label has been added. Git tree hash: 527800db6706d66617ed88beffdd5b227310da3b
|
kubermatic-bot
added
the
approved
alvaroaleman
force-pushed
the
current-context-bootstrap
branch
from
fee0576
to
b45932b
Compare
|
@themue I've added some comments explaining the rationale for this, I hope they make it easier to understand and also prevents ppl from removing the code in the future because they don't understand the purpose |
|
LGTM label has been added. Git tree hash: 9db3720eff3cd134e342223f8bde94a46ad2d7c8
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: themue The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
/hold cancel |
kubermatic-bot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
/assing @thz