Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Loki to 2.2.1 #31

Merged
merged 1 commit into from
Jun 23, 2021
Merged

Upgrade Loki to 2.2.1 #31

merged 1 commit into from
Jun 23, 2021

Conversation

jiachengxu
Copy link
Contributor

No description provided.

@jiachengxu
Copy link
Contributor Author

/test

@kubermatic-bot
Copy link

@jiachengxu: The /test command needs one or more targets.
The following commands are available to trigger jobs:

  • /test pull-mla-validate-prow-yaml

Use /test all to run all jobs.

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jiachengxu
Copy link
Contributor Author

/test all

@jiachengxu
Copy link
Contributor Author

/close

@kubermatic-bot
Copy link

@jiachengxu: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jiachengxu
Copy link
Contributor Author

/reopen

@kubermatic-bot
Copy link

@jiachengxu: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot added the dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. label Jun 23, 2021
@kubermatic-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiachengxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 23, 2021
@rastislavs
Copy link
Contributor

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 23, 2021
@kubermatic-bot
Copy link

LGTM label has been added.

Git tree hash: ab2b9e2fcf8af4884862a6da2cf519a32976d633

@kubermatic-bot kubermatic-bot merged commit e757bb4 into main Jun 23, 2021
@kubermatic-bot kubermatic-bot deleted the upgrade-loki branch June 23, 2021 11:27
@@ -90,6 +90,12 @@ loki:

tableManager:
enabled: true
extraArgs:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need s3 for tableManager?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is needed, otherwise it will throw AWS credential error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants