Skip to content

move to .NET Standard 2.0 #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 15, 2017

Conversation

colemickens
Copy link
Contributor

Looks like the X509Certificate2 API is slightly different...

@colemickens
Copy link
Contributor Author

(It seems that .NET Standard 2.0 still doesn't seem to support non-PFX scenarios around x509)

@colemickens
Copy link
Contributor Author

colemickens commented Sep 14, 2017

When running the example, I get this:

Unhandled Exception: System.AggregateException: One or more errors occurred. (The handler does not support client authentication certificates with this combination of libcurl (7.55.1) and its SSL backend ("OpenSSL/1.1.0f").) ---> System.PlatformNotSupportedException: The handler does not support client authentication certificates with this combination of libcurl (7.55.1) and its SSL backend ("OpenSSL/1.1.0f").

@colemickens colemickens changed the title move to .NET Standard 2.0 [wip] move to .NET Standard 2.0 Sep 14, 2017
@colemickens
Copy link
Contributor Author

colemickens commented Sep 14, 2017

It appears the error I've listed is unrelated to moving it to .NETStandard2 and is rather just a deficiency in corefx on Linux/OSX. If I replace my libcurl4 with one built against openssl1.0.0, then it works. Not sure how common that is among modern distros...

This was my workaround in Arch Linux for anyone that winds up here via Google:

$ pacaur -S libcurl-openssl-1.0.0
$ cd examples/simple
$ LD_LIBRARY_PATH=/usr/lib/libcurl-openssl-1.0.0/:$LD_LIBRARY_PATH dotnet run

Starting Request!
nginx-4217019353-8wb5r

Also, this is probably what I get for not just doing this in a container where there's probably an appropriate version of libcurl.


RE the PR:

I think this can be merged.

@@ -1,6 +1,6 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFramework>netstandard1.6</TargetFramework>
<TargetFramework>netstandard2</TargetFramework>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: netstandard2.0, just to be consistent

@colemickens
Copy link
Contributor Author

Done. Added another commit that removes all the UTF-8 BOMs I could find. It appears VS Code also did some other small cleanups as I touched those files. Hopefully that's okay to bundle in this PR.

@colemickens colemickens changed the title [wip] move to .NET Standard 2.0 move to .NET Standard 2.0 Sep 14, 2017
@brendandburns
Copy link
Contributor

LGTM, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants