-
Notifications
You must be signed in to change notification settings - Fork 309
move to .NET Standard 2.0 #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move to .NET Standard 2.0 #23
Conversation
(It seems that .NET Standard 2.0 still doesn't seem to support non-PFX scenarios around x509) |
When running the example, I get this:
|
It appears the error I've listed is unrelated to moving it to .NETStandard2 and is rather just a deficiency in corefx on Linux/OSX. If I replace my libcurl4 with one built against openssl1.0.0, then it works. Not sure how common that is among modern distros... This was my workaround in Arch Linux for anyone that winds up here via Google:
Also, this is probably what I get for not just doing this in a container where there's probably an appropriate version of libcurl. RE the PR: I think this can be merged. |
src/KubernetesClient.csproj
Outdated
@@ -1,6 +1,6 @@ | |||
<Project Sdk="Microsoft.NET.Sdk"> | |||
<PropertyGroup> | |||
<TargetFramework>netstandard1.6</TargetFramework> | |||
<TargetFramework>netstandard2</TargetFramework> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: netstandard2.0, just to be consistent
c5aab15
to
2a2e013
Compare
Done. Added another commit that removes all the UTF-8 BOMs I could find. It appears VS Code also did some other small cleanups as I touched those files. Hopefully that's okay to bundle in this PR. |
LGTM, thanks! |
Looks like the X509Certificate2 API is slightly different...