Skip to content

Conversation

tg123
Copy link
Member

@tg123 tg123 commented May 7, 2022

  • update api model to v1.24
  • support api group

api group [breaking change to code]

why this change

before api group, apis with same operationid, for example getAPIResources, were suffixed with a number which does not make any sense.
this change is also aligning api style with other sdk, for example, java

new api exmaple

before

client.ListNamespacedPod("default");

after

client.CoreV1.ListNamespacedPod("default");

something should follow up
client.CoreV1 creates a new object each time which can be optimized and cached

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 7, 2022
@k8s-ci-robot k8s-ci-robot requested a review from brendandburns May 7, 2022 16:04
@brendandburns
Copy link
Contributor

/lgtm
/approve

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 7, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, tg123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [brendandburns,tg123]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants