-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom object status and scale api #72
Add custom object status and scale api #72
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
If this file is really supposed to be written by hand like done now it should be a yaml file not json, that would avoid a huge amount of duplication via yaml anchors. Also why are the custom object read calls named |
This looks good. I'm going to merge. wrt to wrt JSON vs YAML I don't think there is a strong feeling one way or the other. If you want to change this to YAML and the python code to load YAML instead JSON that seems fine to me. Ultimately hand maintaining this is probably a mistake, we should generate it from the original golang struct or some-such. Anyway, I'm going to merge this, and we can do those other things in the future. |
"produces": [ | ||
"application/json", | ||
"application/yaml", | ||
"application/vnd.kubernetes.protobuf" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Custom resources don't support protobuf. I'm not sure if yaml is supported though.
After a discussion with @yliaog, we want to keep the changes between beta release and GA release minimum for python-client release (I'll update devel documentation about the release procedure). We decided to not include this new API change in python-client v7.0.0. Let's fix this spec and introduce the API to v8.
The api is beta in kubernetes 1.11
Closes gh-71