Skip to content

add jonschoning as an owner #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 16, 2019

Conversation

guoshimin
Copy link
Contributor

@jonschoning let me know if it's ok with you.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 13, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guoshimin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 13, 2019
@jonschoning
Copy link
Contributor

Sure, It's OK with me—thanks!

@guoshimin
Copy link
Contributor Author

/lgtm

@k8s-ci-robot
Copy link
Contributor

@guoshimin: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@guoshimin
Copy link
Contributor Author

@jkachmar can you /lgtm this?

@jkachmar
Copy link

/lgtm

@k8s-ci-robot
Copy link
Contributor

@jkachmar: changing LGTM is restricted to assignees, and only kubernetes-client/haskell repo collaborators may be assigned issues.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@guoshimin
Copy link
Contributor Author

guoshimin commented Mar 15, 2019 via email

@guoshimin
Copy link
Contributor Author

/assign @jkachmar

@k8s-ci-robot
Copy link
Contributor

@guoshimin: GitHub didn't allow me to assign the following users: jkachmar.

Note that only kubernetes-client members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @jkachmar

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jonschoning
Copy link
Contributor

brendandburns invited me as a collaborator on the kubernetes-client/haskell repository via a github email. Assuming he's done the same for jkachmar, I'm guessing jkachmar needs accept that email invitation first.

@guoshimin
Copy link
Contributor Author

guoshimin commented Mar 16, 2019 via email

@guoshimin
Copy link
Contributor Author

guoshimin commented Mar 16, 2019

@jonschoning can you comment /lgtm and see if that works?

@jonschoning
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 16, 2019
@k8s-ci-robot k8s-ci-robot merged commit b734f3e into kubernetes-client:master Mar 16, 2019
@guoshimin guoshimin deleted the patch-2 branch March 16, 2019 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants