Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
V1Secret equals always returns false #431
Two V1Secret instances deserialized from the same YAML are not equal. In fact,
Would you be open to patches for this? If so, what's the right approach? Keep the
This is really very unfortunate. That code is generated, so we can't manually patch it. We could override it with our own class (similar to IntToString or Quantity) if we really wanted to.
Alternately, we could update the SwaggerCodegen here:
To be smarter...
@davidxia unfortunately, I don't think that PR fixes this issue. The object in question here is a
Looking at the code, I think the right answer is to use
We should do a PR into swagger-code to update to
I took a closer look at this and it seems
This will go here
So I think using both
Wow, that's really unfortunate. It feels like a bug in the Java code, I would have expected
We could in theory hack up the swagger codegen to detect maps and do the right thing here itself (recursively, of course).
It feels like a lot of work for small payoff, but we can keep the issue open in case someone wants to take it up...