Removing unused imports and adding a log parameter for placeholder #1063
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XS
|
/assign @brendandburns |
| @@ -125,6 +125,7 @@ public void addEventHandlerWithResyncPeriod( | |||
| log.warn( | |||
| "DefaultSharedIndexInformer#resyncPeriod {} is smaller than resyncCheckPeriod {} and the informer has already started. Changing it to {}", | |||
| resyncPeriodMillis, | |||
| resyncCheckPeriodMillis, | |||
There was a problem hiding this comment.
why is this change needed?
There was a problem hiding this comment.
If you look at the log message- "DefaultSharedIndexInformer#resyncPeriod {} is smaller than resyncCheckPeriod {} and the informer has already started. Changing it to {}". It has 3 placeholders but we are supplying only 2 variables to log.
There was a problem hiding this comment.
I can remove this if this looks redundant.
There was a problem hiding this comment.
No that's fine, I was just confused about how adding a parameter was necessary if it was compiling before, but now I realize that it's a varargs function.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, sarveshkaushal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
I have added 2 changes: