Fix javadocs in examples submodule #142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lwander
reviewed
Dec 8, 2017
| @@ -26,10 +26,10 @@ | |||
| /** | |||
| * A simple example of how to use the Java API | |||
| * | |||
| * Easiest way to run this: | |||
| * <p>Easiest way to run this: | |||
There was a problem hiding this comment.
Do these tags need to be terminated?
There was a problem hiding this comment.
In theory yes, but all browsers handle unterminated
correctly for legacy reasons
There was a problem hiding this comment.
In theory yes, but all browsers handle unterminated
correctly for legacy reasons
There was a problem hiding this comment.
The HTML specs say closing tags can be omitted for p tags. https://stackoverflow.com/a/33787857/553994 I got used to doing this in javadocs but can add them here if you’d like.
|
@lwander unless you care about the |
|
I don't mind the missing |
|
Thanks
--
David Xia
davidxia.com
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.