Update the CustomConstructor class for SnakeYAML. #1676
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
k8s-ci-robot
added
size/S
brendandburns
changed the title
k8s-ci-robot
added
size/M
yue9944882
reviewed
May 6, 2021
| @@ -357,8 +360,11 @@ protected NodeTuple representJavaBeanProperty( | |||
| } | |||
|
|
|||
| /** @return An instantiated SnakeYaml Object. */ | |||
| public static org.yaml.snakeyaml.Yaml getSnakeYaml() { | |||
There was a problem hiding this comment.
this is a public method, should we mark it as deprecated and keep this for 1~2 releases for backward-compatibility?
There was a problem hiding this comment.
Done. (though this should really be private)
k8s-ci-robot
added
the
lgtm
This was referenced May 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @yue9944882