-
Notifications
You must be signed in to change notification settings - Fork 2k
Update dependencies except for Spring #2768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies except for Spring #2768
Conversation
Thanks for the PR. I'm wondering if dependabot doesn't do this b/c there are explicit versions in okhttp or somesuch? Anyway, assuming tests pass: /lgtm |
fwiw, dependabot did send one of them: |
Yes, it's good, of course, that Dependabot found this update. That does leave a mystery of why it never offered PR's for the other updates. I looked at the configuration and it's the simple, typical configuration found in many other projects. Because I could see that the okhttp update had not occurred, I ran |
/lgtm |
Yeah, it's odd it looks like dependabot has never offered an update for https://github.com/search?q=repo%3Akubernetes-client%2Fjava+okhttp&type=pullrequests |
@rjeberhard looks like the logback dependency doesn't support Java8? |
@rjeberhard b/c this PR needs a little more work, I merged the protobuf change, so you'll need to rebase. Apologies for the extra work. |
Yeah, I was too hopeful that I'd be able to do all of the updates. I think that the best plan would be to have specific PR's for each dependency similar to what Dependabot should have created. |
Ok, individual targetted PRs makes sense. I also wonder if we need to move java8 support out into a different fork or some other approach to continuing support for Java8... |
I looked into this more I think logback should move to 1.3.11 not 1.4.11 they claim to be identical except 1.3 supports Java 8... |
Since this PR is down to just 2 changes, this seems close enough to the goal of having individual PR's. In the future, I'll create individual PR's if Dependabot doesn't generate the necessary updates. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, rjeberhard The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
We're seeing OWASP scan reports about okio, which is included by okhttp3. I'm curious about why Dependabot didn't update this dependency? Whatever the answer, here are all of the missing updates except for those from Spring, which seem to require other, compensating changes.