Reduce allocations in ProtoClient codec #3139
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to understand the proto client and noticed some things that could be improved, if you are pretty familiar with how okio works. I ran the ProtoExample afterwards and it has the same behaviors.
Note: The upstream ApiClient isn't managing resources very well, particularly ensuring responses close. So, even though I adjusted in proto, there are other paths which can leak responses, especially on exception.