Add an authenticator interface and implementation. #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lwander
approved these changes
Jun 29, 2017
| String name = (String) authConfig.get("name"); | ||
| Authenticator auth = authenticators.get(name); | ||
| if (auth != null) { | ||
| // TODO: Persiter here. |
| @Override | ||
| public String getToken(Map<String, Object> config, ConfigPersister persister) { | ||
| Date expiry = (Date) config.get("expiry"); | ||
| if (expiry != null && expiry.compareTo(new Date()) <= 0) { |
There was a problem hiding this comment.
Don't all tokens expire? Can this be moved in to an abstract super class with an abstract refreshToken method?
There was a problem hiding this comment.
Refactored to do this.
| * @param config The new configuration to persist | ||
| * @throws IOException when an error occurs while persisting | ||
| */ | ||
| void persistConfig(String name, Map<String, Object> config) throws IOException; |
There was a problem hiding this comment.
Why is the authenticator name required? It seems strange that you pass the ConfigPersister to getToken in the Authenticator which will always have to supply its own name to persistConfig.
There was a problem hiding this comment.
I was emulating what client-go does, but I got rid of this (and I like it better now, so thanks for the feedback!)
brendandburns
force-pushed
the
plugins
branch
3 times, most recently
from
6ad6f3b to
a7a0c57
Compare
lwander
approved these changes
Jul 5, 2017
|
@lwander rebased, let me know if you have any last comments, otherwise, I'll merge later today. Thanks! |
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix for #35